Re: [PATCH v2] usb host: Faraday FUSBH200 HCD driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 1 Apr 2013, Yuan-Hsin Chen wrote:

> FUSBH200 is an ehci-like controller with some differences.
> First, register layout of FUSBH200 is incompatible with EHCI.
> We use a quirk flag and modify struct ehci_regs with anonymous
> union and struct to make sure driver of FUSBH200 and EHCI could
> coexist. Furthermore, FUSBH200 is lack of siTDs which means iTDs
> are used for both HS and FS ISO transfer.

Now that I see this, I think the incompatibilities are too big and 
using a quirk flag just makes the code a lot harder to understand and 
maintain.  Maybe it would be best to use the original version of your 
driver after all.

I'm sorry to have put you through all this extra effort.

Have you checked that your driver works with the current 3.9-rc 
kernel?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux