On Sat, Mar 30, 2013 at 02:46:20AM +0200, Alexander Shishkin wrote: > As part of the legacy from the original driver design, we retain home-grown > tracing infrastructure, complete with own ring buffer and timestamps. While > it is useful for debugging certain cases, it's a lot of extra code, which > these days is rather redundant. > > This patch replaces local tracing functionality with kernel tracepoints, > thus getting rid of the ring buffer and all the maintenance code, while > making use of standard kernel infrastructure. What do these tracepoints do? Why do you still need them at all? Once you make a tracepoint, you are saying you are going to keep that api for forever, are you really willing to do that? I'm not, which is why you don't see any USB tracepoints yet, and I really don't think that a single driver needs them either. So I need a whole lot of convincing before I can take a patch like this, sorry. I took the first 3 patches here, but odds are, if I can't take this one, the rest will not apply, right? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
