Re: [PATCH v9 0/8] usb: chipidea: udc: cleanups and fixes for v3.10

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> writes:

> Hi,

Hi,

> this series contains simples fixes and cleanup patches for
> the chipidea udc. It is based on Alexander Shishkins ci-for-greg.

This is not really true, since your 7/8 relied on the alignment fix,
which didn't make it anywhere yet.

Some other problems I found:

> Michael Grzeschik (8):
>   usb: chipidea: udc: only clear active and halted bits in qhead
>   usb: chipidea: udc: move ZLT flag change to ep_enable
>   usb: chipidea: udc: read status of td only once in hardware_dequeue

This one tried to convert endianness the wrong way.

>   usb: chipidea: udc: rework ep_enable cap setting

This one is much better in front of the ZLT flag patch, makes it easier
to read both. Especially after I dropped the extra isoc bit.

>   usb: chipidea: udc: don't truncate requests to single tds
>   usb: chipidea: udc: move _ep_queue into an unlocked function
>   usb: chipidea: udc: prepare qhead with dma_alloc_coherent

Didn't apply (see above), so I left it out for now.

>   usb: chipidea: udc: add the define TD_PAGE_COUNT and fix all users

I was tempted to move this one in front of "don't truncate requests",
but left it like this in the end.

So after fixing these I applied it and pushed to ci-for-greg.

Thanks,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux