On Thu, Mar 28, 2013 at 10:32:53PM +0000, David Howells wrote: > Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> wrote: > > > I'm a little bit confused about your description for the second one. > > Did you need to change the #defines names because they could conflict > > with other drivers when the xHCI driver is built in? Or is there some > > other point I'm missing? > > Sorry, I should say. I'm trying to clean up the UAPI headers and I noticed > that the xHCI SEGMENT_SIZE macro is named the same as one defined by a.out.h > that cannot be changed as it is seen by userspace. Although it's unlikely > that within the kernel they are unlikely to collide, one cannot be entirely > sure that will stay true as new arches get added (hopefully no one will add > new arches that use a.out format). It seems best that the xHCI one be renamed > if possible. I guess my question is a deeper one: do we need to rename all the xHCI macros to have the XHCI_ prefix, in order to avoid future collision? For example, one of the macros is MAX_HC_PORTS, which could possibly be used by other host drivers in the future. Note that I'm not asking you to do this, just if it needs to be done. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
