Re: [PATCH v7 0/6] usb: chipidea: udc: bugfixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 27, 2013 at 06:35:30PM +0200, Alexander Shishkin wrote:
> Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> writes:
> 
> > Hi,
> >
> > this series solve some issues with the chipidea udc.
> >
> > The series is based on v3.9-rc4.
> >
> > Michael Grzeschik (6):
> >   usb: chipidea: udc: add attribute aligned(4) to shared memory structs
> >   usb: chipidea: udc: only clear active and halted bits in qhead
> >   usb: chipidea: udc: move ZLT flag change to ep_enable
> >   usb: chipidea: udc: read status of td only once in hardware_dequeue
> >   usb: chipidea: udc: don't truncate requests to single tds
> >   usb: chipidea: udc: move _ep_queue into an unlocked function
> 
> Actually, do any of these patches fix tangible bugs, that can be
> reproduced? If so, you should certainly mention that. But somehow I doubt
> that, because otherwise the driver will be totally unusable.
> 
> What I see is patches that bring some parts of udc code in accordance
> with the spec, which is a good thing to do, but doesn't fix any "real
> bugs that bother people". Or does it?

Obviously we were hunting a real issue while writing that patches. The
most essential one is Patch 1/6, which definitely is a stable patch. I
will clearify that in the patch description.

The others though should go into v3.10, agreed?

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux