Re: [PATCH V4 0/2] UVC webcam gadget related changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Felipe,

On Wednesday 27 March 2013 15:33:15 Felipe Balbi wrote:
> On Thu, Mar 21, 2013 at 01:56:07PM +0530, Bhupesh Sharma wrote:
> > This patchset tries to enhance the UVC webcam gadget driver and is based
> > on Laurent's git tree available here (head uvc-gadget):
> > git://linuxtv.org/pinchartl/uvcvideo.git
> > 
> > Note that to ease review and integration of these patches, I have rebased
> > them on Laurent's repo and all the relevant patches after review can be
> > pushed in Felipe's repo in one go.
> > 
> > The patches 1/2 and 2/2 in this patchset try to handle all the review
> > comments received on the following UVC gadget related patches:
> > 
> > [PATCH V3 3/5] usb: gadget/uvc: Port UVC webcam gadget to use
> > 
> > 		videobuf2 framework
> > 
> > [PATCH V3 5/5] usb: gadget/uvc: Add support for 'get_unmapped_area'
> > 
> > 		for MMUless architectures
> > 
> > which can be viewed here:
> > [1] http://comments.gmane.org/gmane.linux.usb.general/77772
> > [2] http://www.spinics.net/lists/linux-usb/msg77400.html
> > 
> > The rest of the patches in the V3 patchset have already been accepted
> > into Laurent's git tree.
> > 
> > I have tested this patchset on a super-speed compliant USB device
> > controller (DWC3), with the VIVI capture device acting as a dummy source
> > of video data and I also have modified the 'uvc-gadget' application
> > written by Laurent (original application available here:
> > http://git.ideasonboard.org/uvc-gadget.git) for testing the complete flow
> > from V4L2 to UVC domain and vice versa.
> > 
> > I will send a patch for the modified 'uvc-gadget' application in a
> > separate patch.
> > 
> > Changes since V3:
> > - Addresses the review comments received on V3 of this patchset from
> >   Laurent and Michael Grzeschik.
> > 
> > - The changes suggested by Laurent and Alan to remove WARN_ON messages
> >   from the UDC controller drivers in case the gadget tries to dequeue a
> >   USB request which was never queued to the UDC controller, will be
> >   floated as a separate patch.
> 
> Laurent, are you giving your Ack here ? It has been almost a week since
> these were sent to linux-usb.

I'm reviewing the patches.

-- 
Regards,

Laurent Pinchart

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux