Hi Felipe, On Wednesday 27 of March 2013 15:19:58 Felipe Balbi wrote: > Hi, > > On Tue, Mar 26, 2013 at 03:53:12PM +0100, Tomasz Figa wrote: > > @@ -307,6 +310,7 @@ static int samsung_usb3phy_remove(struct > > platform_device *pdev)> > > static struct samsung_usbphy_drvdata usb3phy_exynos5 = { > > > > .cpu_type = TYPE_EXYNOS5250, > > .devphy_en_mask = EXYNOS_USBPHY_ENABLE, > > > > + .rate_to_clksel = samsung_usbphy_rate_to_clksel_4x12, > > why isn't this just a clk_get_rate() ??? As the name suggests, this is a function to get appropriate CLKSEL value to write into PHYCLK register for reference clock rate on particular platform (clk_get_rate is used inside to get the rate). Best regards, -- Tomasz Figa Samsung Poland R&D Center SW Solution Development, Kernel and System Framework -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html