Hi,
On Fri, Mar 22, 2013 at 09:30:17AM +0200, Felipe Balbi wrote:
> this driver compiles fine everywhere which
> means we can use linux-next to compile it
> for us frequently.
>
> By dropping the arch dependency, we also
> ensure driver writers don't add virtual
> arch-depdencies to the driver by e.g. using
> the wrong headers.
>
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> ---
> drivers/usb/gadget/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index af5cc35..261b1e3 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -324,7 +324,6 @@ config USB_MV_UDC
>
> config USB_MV_U3D
> tristate "MARVELL PXA2128 USB 3.0 controller"
> - depends on CPU_MMP3
there's one piece missing here. Marvell's PHY dependency is bogus.
Currently PHY depends on UDC, which is nonsense. This means that by
dropping ARCH dependency on this driver, which builds fine everywhere,
we can could try to build PHY in Arches which don't provide
writel_relaxed and readl_relaxed.
I fixed the original commit since it wasn't in my next branch yet, see
below:
commit 60630c2eabd40fb119a1b88af364003d2915b370
Author: Felipe Balbi <balbi@xxxxxx>
Date: Fri Mar 22 09:15:45 2013 +0200
usb: gadget: mv_u3d: drop ARCH dependency
this driver compiles fine everywhere which
means we can use linux-next to compile it
for us frequently.
By dropping the arch dependency, we also
ensure driver writers don't add virtual
arch-depdencies to the driver by e.g. using
the wrong headers.
While at that, fix Marvell's USB3 PHY dependency,
that's the driver which depends on CPU_MM3, not
mv_u3d_core.
Signed-off-by: Felipe Balbi <balbi@xxxxxx>
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index af5cc35..261b1e3 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -324,7 +324,6 @@ config USB_MV_UDC
config USB_MV_U3D
tristate "MARVELL PXA2128 USB 3.0 controller"
- depends on CPU_MMP3
help
MARVELL PXA2128 Processor series include a super speed USB3.0 device
controller, which support super speed USB peripheral.
diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index 7e8fe0f..372db48 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -45,7 +45,7 @@ config ISP1301_OMAP
config MV_U3D_PHY
bool "Marvell USB 3.0 PHY controller Driver"
- depends on USB_MV_U3D
+ depends on CPU_MMP3
help
Enable this to support Marvell USB 3.0 phy controller for Marvell
SoC.
--
balbi
Attachment:
signature.asc
Description: Digital signature
