Re: [PATCH v4 00/12] usb: chipidea: udc: fixes, iso ep and multi td support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michael Grzeschik <mgr@xxxxxxxxxxxxxx> writes:

> On Tue, Mar 26, 2013 at 08:01:56PM +0200, Felipe Balbi wrote:
>> On Tue, Mar 26, 2013 at 05:58:36PM +0100, Michael Grzeschik wrote:
>> > Hi all,
>> > 
>> > this series fixes an issue which leads the hardware to get stuck after
>> > reading dirty values from the shared memory mapped QHs and TDs. It also
>> > changes the code to be more precise with the constraints from the
>> > datasheet.
>> > 
>> > It adds support to handle requests which spawns into several TDs. And
>> > additionally addresses the isochronous support for the chipidea udc and
>> > removes not needed lock state juggling.
>> > 
>> > The series is based on Alexander Shishkins ci-for-greg branch.
>> > 
>> > Regards,
>> > Michael
>> > 
>> > Michael Grzeschik (12):
>> >   usb: chipidea: udc: add attribute aligned(4) to shared memory structs
>> >   usb: chipidea: udc: only clear active and halted bits in qhead
>> 
>> create the habit of splitting bug fixes out to a separate series and
>> make sure next patches don't depend on the fixes themselves, where
>> possible.
>> 
>> If you don't do that, maintainers might miss the bugfix and we end up
>> with a buggy v3.9.
>
> I will rework that series.

Also, when you resend this patchset, *please* make sure all the patches
in it have the same version number, which is greater than *any* of these
patches had before. Right now your 0/12 is v4, and the patches contained
therein are anything between v2 and v5 and 1/12 doesn't have a
version. This sends my head spinning.

Thanks,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux