On Tue, 26 Mar 2013, Arnd Bergmann wrote: > On Tuesday 26 March 2013, Florian Fainelli wrote: > > > > Just like the OHCI counter part we just can remove the architecture > > specific symbols which prevent these configuration symbols from being > > selected by platforms/architectures requiring it. The original > > implementation did not scale at all since it required each and every > > single architecture to be added for these configuration symbols to be > > selected. Now it is up to the EHCI driver and/or platform to select > > these configuration symbols accordingly. > > > > Signed-off-by: Florian Fainelli <florian@xxxxxxxxxxx> > > Good idea, just one suggestion: > > > config USB_EHCI_BIG_ENDIAN_MMIO > > bool > > - depends on USB_EHCI_HCD && (PPC_CELLEB || PPC_PS3 || 440EPX || \ > > - ARCH_IXP4XX || XPS_USB_HCD_XILINX || \ > > - PPC_MPC512x || CPU_CAVIUM_OCTEON || \ > > - PMC_MSP || SPARC_LEON || MIPS_SEAD3) > > - default y > > + depends on USB_EHCI_HCD > > + default n > > > > config USB_EHCI_BIG_ENDIAN_DESC > > bool > > - depends on USB_EHCI_HCD && (440EPX || ARCH_IXP4XX || XPS_USB_HCD_XILINX || \ > > - PPC_MPC512x || PMC_MSP || SPARC_LEON || \ > > - MIPS_SEAD3) > > - default y > > + depends on USB_EHCI_HCD > > + default n > > > > config XPS_USB_HCD_XILINX > > bool "Use Xilinx usb host EHCI controller core" > > You can drop the "default n" line as well, it's the default. The "depends on USB_EHCI_HCD" isn't really needed either. The build system might get confused if platform code selects USB_EHCI_BIG_ENDIAN_DESC but for some reason USB_EHCI_HCD isn't enabled. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
