Re: [PATCH v3 11/12] usb: chipidea: udc: manage dynamic amount of tds with an linked list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Mar 26, 2013 at 05:58:47PM +0100, Michael Grzeschik wrote:
> Instead of having a limited number of usable tds in the udc we use a
> linked list to support dynamic amount of needed tds for all special
> gadget types. This improves throughput.
> 
> This patch also adresses a possible momory leak in _ep_nuke found

this mem leak should be split to a separate patch and sent as a bugfix.

> +static int add_td_to_list(struct ci13xxx_ep *mEp, struct ci13xxx_req *mReq, unsigned length, gfp_t gfp_flags)

are you sure checkpatch.pl didn't complain about this line ?

fix these two comments and you can add:

Reviewed-by: Felipe Balbi <balbi@xxxxxx>

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux