Re: [PATCH v2 02/12] usb: chipidea: udc: only clear active and halted bits in qhead

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 26, 2013 at 05:58:38PM +0100, Michael Grzeschik wrote:
> The datasheet of the synopsys core describes only to overwrite the
> active and halted bits in the qhead before priming any endpoint.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> ---
> Changes since v1:
>  - rebased on the new alignment patch
> 
>  drivers/usb/chipidea/udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index 13fffcc..5ffffad 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -473,7 +473,7 @@ static int _hardware_enqueue(struct ci13xxx_ep *mEp, struct ci13xxx_req *mReq)
>  
>  	/*  QH configuration */
>  	mEp->qh.ptr->td.next   = mReq->dma;    /* TERMINATE = 0 */
> -	mEp->qh.ptr->td.token &= ~TD_STATUS;   /* clear status */
> +	mEp->qh.ptr->td.token &= ~(TD_STATUS_HALTED|TD_STATUS_ACTIVE);   /* clear status */

looks like a bug fix which deserves Cc: stable, no ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux