Re: [PATCH] USB: EHCI: DT support for generic bus glue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 26 Mar 2013, Tony Prisk wrote:

> Hi Alan,
> 
> I noticed when testing Arnd's patch that I get an unused function
> warning:
> 
> drivers/usb/host/ehci-q.c:1320:13: warning:
> ‘unlink_empty_async_suspended’ defined but not used [-Wunused-function]
> 
> 
> It looks like this function is called from ehci-hub.c:ehci_bus_suspend()
> which is wrapped in a #ifdef CONFIG_PM.

Ooh, yes.

> I guess the forward decl in ehci-hcd.c:
> static void unlink_empty_async_suspended(struct ehci_hcd *ehci)
> 
> and the actual function in ehci-q.c need to be wrapped in a #ifdef
> CONFIG_PM as well.

Well, the declaration doesn't matter.  But the function itself does 
need to be wrapped.

> Let me know if you want me to send a patch for this.

Yes, please.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux