Re: [PATCH 02/12] usb: chipidea: udc: only clear active and halted bits in qhead

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 22, 2013 at 02:20:24PM +0100, Michael Grzeschik wrote:
> The datasheet of the synopsys core describes only to overwrite the
> active and halted bits in the qhead before priming any endpoint.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> ---
>  drivers/usb/chipidea/udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index fd702e9..e15f5e5 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -472,7 +472,7 @@ static int _hardware_enqueue(struct ci13xxx_ep *mEp, struct ci13xxx_req *mReq)
>  	}
>  	/*  QH configuration */
>  	writel(mReq->dma, &mEp->qh.ptr->td.next); /* TERMINATE = 0 */
> -	writel(readl(&mEp->qh.ptr->td.token) & ~TD_STATUS, &mEp->qh.ptr->td.token);
> +	writel(readl(&mEp->qh.ptr->td.token) & ~(TD_STATUS_HALTED|TD_STATUS_ACTIVE), &mEp->qh.ptr->td.token);
>  	writel(readl(&mEp->qh.ptr->cap) | QH_ZLT, &mEp->qh.ptr->cap);
>  
>  	wmb();   /* synchronize before ep prime */
> -- 
> 1.8.2.rc2
> 
> 
Reviewed-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>

-- 

Best Regards,
Peter Chen

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux