Re: [PATCH] USB: hub: Avoid NULL pointer dereference when hub doesn't have any ports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 25, 2013 at 10:50:27AM +0000, David Linares wrote:
> Return an error if hub->descriptor->bNbrPorts==0. Without this additional
> check, we can end up doing a "hub->ports = kzalloc(0, GFP_KERNEL)".
> This hub->ports pointer will therefore be non-NULL and will be used.
> Example of dmesg:
>    INIT: usb 1-1: New USB device found, idVendor=0424, idProduct=2512
>    usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
>    hub 1-1:1.0: USB hub found
>    version 2.86 bootinghub 1-1:1.0: 0 ports detected
>    Unable to handle kernel NULL pointer dereference at virtual address 00000010

How can a hub not have any ports?  That kind of defeats the goal of
having a hub at all.

Not to say your patch isn't good, I'll take it, but this does sound
quite odd.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux