On Mon, Mar 25, 2013 at 08:53:39AM +0000, Jingoo Han wrote: > Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following > build warning when CONFIG_PM_SLEEP is not selected. This is because > sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used > when the CONFIG_PM_SLEEP is enabled. Unnecessary CONFIG_PM ifdefs > are removed. > > Switch to using SIMPLE_DEV_PM_OPS macro to declare the driver's > pm_ops. It reduces code size. > > drivers/usb/dwc3/core.c:682:12: warning: 'dwc3_suspend' defined but not used [-Wunused-function] > drivers/usb/dwc3/core.c:709:12: warning: 'dwc3_resume' defined but not used [-Wunused-function] > drivers/usb/dwc3/dwc3-omap.c:430:12: warning: 'dwc3_omap_suspend' defined but not used [-Wunused-function] > drivers/usb/dwc3/dwc3-omap.c:440:12: warning: 'dwc3_omap_resume' defined but not used [-Wunused-function] > drivers/usb/dwc3/dwc3-exynos.c:185:12: warning: 'dwc3_exynos_suspend' defined but not used [-Wunused-function] > drivers/usb/dwc3/dwc3-exynos.c:194:12: warning: 'dwc3_exynos_resume' defined but not used [-Wunused-function] > > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > --- > Changes since v1: > - Removed unnecessary CONFIG_PM ifdefs > - Used SIMPLE_DEV_PM_OPS macro please don't. I explicitly used SET_SYSTEM_SLEEP_PM_OPS() because we will add runtime PM support later. > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index e2325ad..e0847a7 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -634,7 +634,6 @@ static int dwc3_remove(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM > static int dwc3_prepare(struct device *dev) I'm not sure. Should we really provide prepare/complete even when CONFIG_PM_SLEEP isn't enabled ? -- balbi
Attachment:
signature.asc
Description: Digital signature
