On Fri, Mar 22, 2013 at 05:47:53PM -0700, Paul Zimmerman wrote:
> Previously, when an active urb was dequeued, its host channel would
> not always be released. There is some special handling for this in
> dwc2_hc_chhltd_intr_dma, but when it was the last urb/qtd in its qh, a
> safeguard in dwc2_hc_n_intr would short-circuit and prevent the regular
> interrupt handlers from running, without releasing the channel.
>
> This is easily triggered when using a 3G modem using the option driver.
> Opening and closing any ttyUSBx device will eat up a host channel that
> is forever unusable from that point on.
>
> Signed-off-by: Matthijs Kooijman <matthijs@xxxxxxxx>
> Signed-off-by: Paul Zimmerman <paulz@xxxxxxxxxxxx>
since this is basically Matthijs' patch with a few extra details from
you, it should still be marked as authored by Matthijs. All you did was
add a few extra checks for qtd being valid and fixed comment styles.
What you can (should?) do is add a note on commit log specifying what
you have changed, something like below:
commit f27862819350d2c1a679b690b5b3559e632e81eb
Author: supriya karanth <supriya.karanth@xxxxxxxxxxxxxx>
Date: Thu Dec 6 11:16:23 2012 +0530
usb: musb: set AUTOSET for full speed bulk DMA transfer in host mode
The "mult" factor is not updated properly for the can_bulk_split()
case.
The AUTOSET bit in the TXCSR is not being set if the "mult"
factor is greater than 1 for the High Bandwidth ISO case.
But the "mult" factor is also greater than 1 in case of Full speed
bulk transfers with the packet splitting in TXMAXP register
enabled with can_bulk_split().
Without the AUTOSET the DMA transfers will not progress in mode1
[ balbi@xxxxxx : fix braces placement ]
Signed-off-by: supriya karanth <supriya.karanth@xxxxxxxxxxxxxx>
Signed-off-by: Praveena NADAHALLY <praveen.nadahally@xxxxxxxxxxxxxx>
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Signed-off-by: Felipe Balbi <balbi@xxxxxx>
--
balbi
Attachment:
signature.asc
Description: Digital signature
