Re: [PATCH] staging: dwc2: fix wrong setting of DMA masks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

> +	/* Set device flags indicating whether the HCD supports DMA */
> +	if (hsotg->core_params->dma_enable > 0) {
> +		if (dma_set_mask(hsotg->dev, DMA_BIT_MASK(32)) < 0)
> +			dev_warn(hsotg->dev,
> +				 "can't enable workaround for >4GB RAM\n");

Did you intentionally change the workaround here? It used to be 31 bits
and 2GB RAM. Perhaps this deserves a mention in the commit message?

Other than that, the patch looks ok to me.

Gr.

Matthijs
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux