Re: [PATCH] usb: ulpi: Define a *otg_ulpi_create no-op

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Mar 20, 2013 at 11:40:10AM -0300, Fabio Estevam wrote:
> >> +#if IS_ENABLED(CONFIG_USB_ULPI)
> >>  struct usb_phy *otg_ulpi_create(struct usb_phy_io_ops *ops,
> >>                                       unsigned int flags);
> >> +#else
> >> +static inline struct usb_phy *otg_ulpi_create(struct usb_phy_io_ops *ops,
> >> +                                           unsigned int flags)
> >> +{
> >> +     return NULL;
> >
> > Would ERR_PTR(-ENXIO) do better here?
> 
> The real *otg_ulpi_create function returns NULL on errors. Better to
> keep the real and no-op version with the same return type, right?

right :-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux