> -----Original Message----- > From: Stephen Warren [mailto:swarren@xxxxxxxxxxxxx] > Sent: Wednesday, March 20, 2013 1:29 AM > To: Venu Byravarasu > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; stern@xxxxxxxxxxxxxxxxxxx; > balbi@xxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-tegra@xxxxxxxxxxxxxxx; devicetree-discuss@xxxxxxxxxxxxxxxx > Subject: Re: [PATCH 3/7] usb: phy: tegra: Get PHY mode using DT > > On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > > Added a new PHY mode to support OTG. > > Obtained Tegra USB PHY mode using DT property. > > > diff --git a/drivers/usb/phy/tegra_usb_phy.c > b/drivers/usb/phy/tegra_usb_phy.c > > > @@ -713,6 +712,16 @@ struct tegra_usb_phy > *tegra_usb_phy_open(struct device *dev, int instance, > > else > > phy->is_ulpi_phy = true; > > > > + err = of_property_match_string(np, "dr_mode", "otg"); > > + if (err < 0) { > > + err = of_property_match_string(np, "dr_mode", "gadget"); > > + if (err < 0) > > The binding says the 3 legal values for this property are "host", > "peripheral", or "otg". This agrees with the usage in > Documentation/devicetree/bindings/usb/fsl-usb.txt and > drivers/usb/host/fsl-mph-dr-of.c. So, "gadget" is not something the code > should be checking for. Agree, will correct it. > > I'm sure I pointed this out before. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
