> -----Original Message----- > From: Venu Byravarasu > Sent: Wednesday, March 20, 2013 11:30 AM > To: 'Stephen Warren' > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; stern@xxxxxxxxxxxxxxxxxxx; > balbi@xxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-tegra@xxxxxxxxxxxxxxx; devicetree-discuss@xxxxxxxxxxxxxxxx > Subject: RE: [PATCH 0/7] USB: PHY: Tegra: registering TEGRA USB PHY as > platform driver > > > -----Original Message----- > > From: Stephen Warren [mailto:swarren@xxxxxxxxxxxxx] > > Sent: Wednesday, March 20, 2013 1:22 AM > > To: Venu Byravarasu > > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; stern@xxxxxxxxxxxxxxxxxxx; > > balbi@xxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > linux-tegra@xxxxxxxxxxxxxxx; devicetree-discuss@xxxxxxxxxxxxxxxx > > Subject: Re: [PATCH 0/7] USB: PHY: Tegra: registering TEGRA USB PHY as > > platform driver > > > > On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > > > As part of this series, apart from patch containing changes to register > > TEGRA > > > USB PHY driver as platform driver, prepared below patches: > > > 1. Re-arranging & adding new DT properties. > > > 2. Getting various params from DT properties added. > > > 3. code clean up. > > > > Venu, I'm curious whether these patches were tested at all. I have found > > at least two significant problems with trivial testing: > > Stephen, > Initially started testing after applying each and every patch. > Like that tested till first 5 patches. > As did not see any issues till then, applied rest 2 patches at once and tested > with that. > Though did not see mouse getting vbus on the 1st boot, Vbus was coming > fine after disconnect and connect. > Hence did not test thereafter. > > After checking your current mail, tried now and observed that there seems to > be some real issue with patch#7 only. (As tried now after applying till patch# > 6 and did not see this issue). > Will debug further on patch#7 and update with proper fix after addressing > your other comments. Debugged further and found that the issue is because of http://marc.info/?l=linux-arm-kernel&m=135890098024987&w=2 On reverting that patch and applying it on top of patch#7, able to see enumeration working fine. Anyhow, will take care of your other comments and merge this change with patch#7 and resend for review. > > Thanks for the review & heads up, > venu > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
