Re: [PATCH] xhci: Don't warn on empty ring for suspended devices.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 18 Mar 2013 10:25:10 -0700
Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> wrote:

> When a device attached to the roothub is suspended, the endpoint rings
> are stopped.  The host may generate a completion event with the
> completion code set to 'Stopped' or 'Stopped Invalid' when the ring is
> halted.  The current xHCI code prints a warning in that case, which can
> be really annoying if the USB device is coming into and out of suspend.
> 
> Remove the unnecessary warning.
> 
> Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> ---
> 
> Stephen, will you try this patch, and see if your warnings go away?
> 
> Thanks,
> Sarah Sharp


The xHCI warnings go away, but using 3.9-rc3 gives a new warning from USB.
Not sure what colord is doing, I have not color controlled devices on USB, is it
searching for a scanner (there is none)?


[  240.492536] INFO: task colord-sane:3517 blocked for more than 120 seconds.
[  240.492542] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
[  240.492545] colord-sane     D 0000000000000002     0  3517      1 0x00000000
[  240.492552]  ffff88040b4e7808 0000000000000046 0000000000000292 ffff8803fb10a040
[  240.492560]  ffff88040b4e77b8 ffff88040b754300 ffff88040b4e7fd8 0000000000013700
[  240.492570]  ffff88040b4e7fd8 ffff88040b754300 ffff88040b4e7818 ffff88040dc46300
[  240.492579] Call Trace:
[  240.492590]  [<ffffffff814f5b5d>] schedule+0x65/0x67
[  240.492597]  [<ffffffff813d0298>] usb_kill_urb+0xba/0xd8
[  240.492603]  [<ffffffff8109067c>] ? bit_waitqueue+0x8c/0x8c
[  240.492608]  [<ffffffff813d0cbb>] usb_start_wait_urb+0x91/0xd4
[  240.492613]  [<ffffffff813d0f25>] usb_control_msg+0xce/0x100
[  240.492618]  [<ffffffff814f6cad>] ? _raw_spin_unlock_irqrestore+0x3f/0x55
[  240.492623]  [<ffffffff813d1046>] usb_get_status+0x78/0xa4
[  240.492628]  [<ffffffff813cb541>] usb_port_resume+0x23a/0x3ae
[  240.492635]  [<ffffffff810b71f1>] ? mark_held_locks+0x55/0x99
[  240.492639]  [<ffffffff814f6c59>] ? _raw_spin_unlock_irq+0x2e/0x43
[  240.492645]  [<ffffffff813da1c4>] generic_resume+0x1c/0x1e
[  240.492650]  [<ffffffff813d2ac8>] usb_resume_both+0x94/0x106
[  240.492654]  [<ffffffff813d3b86>] ? usb_runtime_suspend+0x5d/0x5d
[  240.492658]  [<ffffffff813d3ba0>] usb_runtime_resume+0x1a/0x1c
[  240.492664]  [<ffffffff8137844e>] __rpm_callback+0x34/0x5b
[  240.492669]  [<ffffffff813784cb>] rpm_callback+0x56/0x79
[  240.492674]  [<ffffffff8137947c>] rpm_resume+0x38a/0x4a7
[  240.492679]  [<ffffffff8109067c>] ? bit_waitqueue+0x8c/0x8c
[  240.492684]  [<ffffffff81379797>] ? __pm_runtime_resume+0x62/0x8d
[  240.492689]  [<ffffffff813797a5>] __pm_runtime_resume+0x70/0x8d
[  240.492693]  [<ffffffff813d34d5>] usb_autoresume_device+0x20/0x3f
[  240.492698]  [<ffffffff813d90ec>] usbdev_open+0xc0/0x237
[  240.492705]  [<ffffffff81159d35>] chrdev_open+0x130/0x15b
[  240.492709]  [<ffffffff81159c05>] ? cdev_put+0x25/0x25
[  240.492714]  [<ffffffff81154c3b>] do_dentry_open+0x182/0x227
[  240.492718]  [<ffffffff81154d15>] finish_open+0x35/0x41
[  240.492722]  [<ffffffff81161e99>] do_last+0x86d/0xa0c
[  240.492727]  [<ffffffff8115fa44>] ? inode_permission+0x45/0x47
[  240.492732]  [<ffffffff811620fe>] path_openat+0xc6/0x32a
[  240.492736]  [<ffffffff8116268c>] do_filp_open+0x38/0x86
[  240.492742]  [<ffffffff8116c30e>] ? spin_unlock+0x9/0xb
[  240.492747]  [<ffffffff8116cf4d>] ? __alloc_fd+0xf3/0x104
[  240.492751]  [<ffffffff811559e0>] do_sys_open+0x6c/0xf9
[  240.492755]  [<ffffffff81155a8e>] sys_open+0x21/0x23
[  240.492761]  [<ffffffff814fdd82>] system_call_fastpath+0x16/0x1b
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux