On Mon, Mar 18, 2013 at 09:28:07AM +0100, oskar.andero@xxxxxxxxxxxxxx wrote: > On 21:16 Fri 08 Mar , Greg Kroah-Hartman wrote: > > On Fri, Mar 08, 2013 at 11:56:26PM +0400, Sergei Shtylyov wrote: > > > Hello. > > > > > > On 08-03-2013 16:53, oskar.andero@xxxxxxxxxxxxxx wrote: > > > > > > >From: Truls Bengtsson <truls.bengtsson@xxxxxxxxxxxxxx> > > > > > > >The udc_irq service runs the isr_tr_complete_handler which in turn > > > >"nukes" the endpoints, including a call to rndis_response_complete, > > > >if appropriate. If the rndis_msg_parser fails here, an error will > > > >be printed using a dev_err call (through the ERROR() macro). > > > > > > >However, if the usb cable was just disconnected the device (cdev) > > > >might not be available and will be null. Since the dev_err macro will > > > >dereference the cdev pointer we get a null pointer exception. > > > > > > >Reviewed-by: Radovan Lekanovic <radovan.lekanovic@xxxxxxxxxxxxxx> > > > >Signed-off-by: Truls Bengtsson <truls.bengtsson@xxxxxxxxxxxxxx> > > > >Signed-off-by: Oskar Andero <oskar.andero@xxxxxxxxxxxxxx> > > > >--- > > > > drivers/usb/gadget/f_rndis.c | 4 ++-- > > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > > > >diff --git a/drivers/usb/gadget/f_rndis.c b/drivers/usb/gadget/f_rndis.c > > > >index 71beeb8..41b5ebd 100644 > > > >--- a/drivers/usb/gadget/f_rndis.c > > > >+++ b/drivers/usb/gadget/f_rndis.c > > > >@@ -6,6 +6,7 @@ > > > > * Copyright (C) 2008 Nokia Corporation > > > > * Copyright (C) 2009 Samsung Electronics > > > > * Author: Michal Nazarewicz (mina86@xxxxxxxxxx) > > > >+ * Copyright (C) 2013 Sony Mobile Communications AB. > > > > > > Your change seems too insignificant to add a copyright. > > > > You are right, it legally is. Truls, please consult your company's > > lawyers if you have questions about this, you can not assert copyright > > over a file for a 2 line change, that's not allowed at all in any > > jurisdiction I know of. > > > > Because of that, I can not accept this change, sorry. > > Thanks for your input guys and I totally agree with you! However, I was > expecting more comments on the cover-letter, or should I take it that this > solution is acceptable? I don't remember, please resend the series after fixing the issues pointed out. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
