On Wed, Mar 13, 2013 at 03:50:32PM -0400, Peter Hurley wrote: > On Thu, 2013-03-07 at 15:55 +0100, Johan Hovold wrote: > > These patches against 3.9-rc1 fix a few issues with tty-port hangup and > > close. > > > > The first and fifth patch are essentially clean ups. > > > > The second and third patch fix the fact that DTR could get raised > > (rather than dropped) at hangup if there are blocked opens. [ Note that > > the second patch has been separated into its own patch and that the > > third patch is new in v3 of this series. ] > > > > The fourth patch makes sure DTR is dropped also on hangup and that DTR > > is only dropped for initialised ports (where it could have been raised > > in the first place). > > > > The sixth and final patch, makes sure no tty callbacks are made from > > tty_port_close_start when the port has not been initialised (successfully > > opened). This was previously only done for wait_until_sent but there's > > no reason to call flush_buffer or to honour port drain delay either. > > The latter could cause a failed open to stall for up to two seconds. > > > > As a side-effect, these patches also fix an issue in USB-serial where we > > could get tty-port callbacks on an uninitialised port after having hung > > up and unregistered a device after disconnect. > > > > Johan > > > > > > v3: > > - amend series with fix of DTR sometimes being raised on hang-up > > - do not lower DTR on hangup if port tty is gone > > - make sure tty in call to shutdown is refcounted > > - use cflag-macros throughout > > Other than the comments for patch 3/6, this series looks good. Thanks > again for your work on this. As I mentioned in my reply to 3/6, fixing bugs in other drivers not using the tty-port implementation is all good but not the purpose of this series. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
