Re: [RFC PATCH 2/3] usb: udc: delete the vbus indicator at individual driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 12, 2013 at 05:03:18PM +0800, Peter Chen wrote:
> Let the common struct usb_gadget own it.
> 
> CC: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
> CC: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>
> CC: Li Yang <leoli@xxxxxxxxxxxxx>
> CC: Roland Stigge <stigge@xxxxxxxxx>
> CC: Yu Xu <yuxu@xxxxxxxxxxx>
> CC: Chao Xie <chao.xie@xxxxxxxxxxx>
> CC: Eric Miao <eric.y.miao@xxxxxxxxx>
> CC: Ben Dooks <ben-linux@xxxxxxxxx>
> Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>

you need to split this patch, should be something like below:

for_each_driver() {
	initialize gadget->vbus_active (don't remove private method)
}

add vbus_active support to udc-core

for_each_driver() {
	remove driver's private vbus_active method
}

you need one patch per driver so it's easy to review and ack.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux