Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 11, 2013 at 06:17:10PM +0800, Chen Gang wrote:
> 于 2013年03月04日 22:35, Felipe Balbi 写道:
> > since stop_activity() also gets called from RESET interrupt, and in that
> > case we need to call driver->disconnect(). Can you make a simple test
> > that would take current code and issue a device reset to see if that
> > would break, then apply my suggestion above and run the same test again?
> 
>   after reference the commit: d93e2600d80fc41ccf339b4a2843a3007d479907
>   it seems udc_start and udc_stop will have effect,
>   so not need call driver->disconnect()
> 
>   is it correct ?

in case of net2272.c and net2280.c, they call stop_activity() also from
disconnect and reset interrupt handlers, in that case the gadget driver
needs to know about the disconnect.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux