On Fri, Mar 08, 2013 at 05:39:53PM +0100, Marc Kleine-Budde wrote:
> On 03/08/2013 05:33 PM, Felipe Balbi wrote:
> > On Thu, Feb 28, 2013 at 11:57:04AM +0100, Marc Kleine-Budde wrote:
> >> @@ -147,19 +146,20 @@ static int ci13xxx_imx_probe(struct platform_device *pdev)
> >> return ret;
> >> }
> >>
> >> - phy_np = of_parse_phandle(pdev->dev.of_node, "fsl,usbphy", 0);
> >> - if (phy_np) {
> >> - data->phy_np = phy_np;
> >> - phy_pdev = of_find_device_by_node(phy_np);
> >> - if (phy_pdev) {
> >> - struct usb_phy *phy;
> >> - phy = pdev_to_phy(phy_pdev);
> >> - if (phy &&
> >> - try_module_get(phy_pdev->dev.driver->owner)) {
> >> - usb_phy_init(phy);
> >> - data->phy = phy;
> >> - }
> >> + phy = devm_usb_get_phy_by_phandle(&pdev->dev, "fsl,usbphy", 0);
> >
> > very nice, but should be done at chipidea core.
>
> Any suggestions for the phandle name? "chipidea,usbphy"?
isn't usbphy or phy enough ? Why do you need the prefix ?
--
balbi
Attachment:
signature.asc
Description: Digital signature
