Re: + drivers-usb-dwc3-ep0c-fix-sparc64-build.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Mar 07, 2013 at 03:14:23PM -0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> 
> The patch titled
>      Subject: drivers/usb/dwc3/ep0.c: fix sparc64 build
> has been added to the -mm tree.  Its filename is
>      drivers-usb-dwc3-ep0c-fix-sparc64-build.patch
> 
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> 
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
> 
> ------------------------------------------------------
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Subject: drivers/usb/dwc3/ep0.c: fix sparc64 build
> 
> drivers/usb/dwc3/ep0.c: In function `__dwc3_ep0_do_control_data':
> drivers/usb/dwc3/ep0.c:905: error: `typeof' applied to a bit-field
> 
> Looks like a gcc-3.4.5/sparc64 bug.
> 
> Cc: Felipe Balbi <balbi@xxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  drivers/usb/dwc3/ep0.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff -puN drivers/usb/dwc3/ep0.c~drivers-usb-dwc3-ep0c-fix-sparc64-build drivers/usb/dwc3/ep0.c
> --- a/drivers/usb/dwc3/ep0.c~drivers-usb-dwc3-ep0c-fix-sparc64-build
> +++ a/drivers/usb/dwc3/ep0.c
> @@ -891,7 +891,8 @@ static void __dwc3_ep0_do_control_data(s
>  				DWC3_TRBCTL_CONTROL_DATA);
>  	} else if (!IS_ALIGNED(req->request.length, dep->endpoint.maxpacket)
>  			&& (dep->number == 0)) {
> -		u32		transfer_size;
> +		u32	transfer_size;
> +		u32	maxpacket;
>  
>  		ret = usb_gadget_map_request(&dwc->gadget, &req->request,
>  				dep->number);
> @@ -902,8 +903,8 @@ static void __dwc3_ep0_do_control_data(s
>  
>  		WARN_ON(req->request.length > DWC3_EP0_BOUNCE_SIZE);
>  
> -		transfer_size = roundup(req->request.length,
> -				(u32) dep->endpoint.maxpacket);
> +		maxpacket = dep->endpoint.maxpacket;
> +		transfer_size = roundup(req->request.length, maxpacket);
>  
>  		dwc->ep0_bounced = true;
>  
> _

now applied to my fixes branch. Please Cc linux-usb on upcoming patches

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux