Re: [PATCH v2 0/7] USB: don't recover device if suspend fails in system sleep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 07, 2013 at 03:28:07PM -0500, David Miller wrote:
> From: Ming Lei <ming.lei@xxxxxxxxxxxxx>
> Date: Fri,  8 Mar 2013 00:15:17 +0800
> 
> > This patch adds comments on interface driver suspend callback
> > to emphasize that the failure return value is ignored by
> > USB core in system sleep context, so do not try to recover
> > device for this case, otherwise the recovery things may confuse
> > resume().
> > 
> > Also fixes the USB serial, HID and several usbnet drivers
> > which may recover device in suspend failure path of system sleep.
> > 
> > v2:
> > 	- improve comments on suspend callback as suggested by Alan
> > 	- update kerneldoc for usb_suspend_both as suggested by Alan
> > 	- remove previous check of PMSG_IS_AUTO(message) in cdc_mbim/
> > 	qmi_wwan and add comments on suspend failure case, since Bjørn
> > 	doesn't like the check.
> > 	- add comments on smsc95xx/smsc75xx
> > v1:
> >         - fix compile failure
> >         - add comments about handling suspend failure in resume()
> 
> Feel free to merge this via the USB tree and to add my ACK to the
> networking driver bits:
> 
> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>

Thanks, I will do that.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux