> From: Felipe Balbi [mailto:balbi@xxxxxx] > Sent: Wednesday, March 06, 2013 11:39 PM > > On Wed, Mar 06, 2013 at 08:14:34PM +0000, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:balbi@xxxxxx] > > > Sent: Wednesday, March 06, 2013 12:11 PM > > > On Wed, Mar 06, 2013 at 07:22:33PM +0000, Paul Zimmerman wrote: > > > > > > > > You still need to set the SusPHY bits, but you only need to do it once. > > > > After that, the core will take care of suspending/resuming the PHYs > > > > at the right time. You will not see the SusPHY bits changing, though. > > > > > > > > Actually, for GUSB2PHYCFG.SusPHY you can't just set it once. You > > > > need to clear it before any register operation that is marked in the > > > > databook with the note "If GUSB2PHYCFG[6] is set to '1', it must be > > > > set to '0' prior to issuing this command and may be set to '1' after > > > > the command completes". Then when the operation completes > > > > you can set it back to 1. > > > > > > What if I set both to zero during driver probe ? Can I then completely > > > forget about them ? > > > > Yes. But then you will be wasting power by having both PHYs always active. > > fair enough, but wouldn't the core take care of the PHYs after probe() ? See above. -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
