Ming Lei <ming.lei@xxxxxxxxxxxxx> writes: > If suspend callback fails in system sleep context, usb core will > ignore the failure and let system sleep go ahead further, so > this patch comments on the case and requires that both > usbnet_suspend() and subdriver->suspend() MUST return 0 in > system sleep context. > > Cc: Bjørn Mork <bjorn@xxxxxxx> > Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxxxxx> > --- > drivers/net/usb/cdc_mbim.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/usb/cdc_mbim.c b/drivers/net/usb/cdc_mbim.c > index 248d2dc..406a34d 100644 > --- a/drivers/net/usb/cdc_mbim.c > +++ b/drivers/net/usb/cdc_mbim.c > @@ -332,6 +332,11 @@ static int cdc_mbim_suspend(struct usb_interface *intf, pm_message_t message) > goto error; > } > > + /* > + * Both usbnet_suspend() and subdriver->suspend() MUST return 0 > + * in system sleep context, otherwise, the resume callback has > + * to recover device from previous suspend failure. > + */ > ret = usbnet_suspend(intf, message); > if (ret < 0) > goto error; Looks fine. Thanks Acked-by: Bjørn Mork <bjorn@xxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
