On Thu, Mar 07, 2013 at 09:16:12AM +0100, Michael Grzeschik wrote: > On Tue, Mar 05, 2013 at 04:40:12PM +0800, Peter Chen wrote: > > On Fri, Mar 01, 2013 at 03:42:26PM +0100, Michael Grzeschik wrote: > > > Instead of having a limited number of usable tds in the udc we use a > > > linked list to support dynamic amount of needed tds for all special > > > gadget types. This improves throughput. > > > > > > This patch also adresses a possible momory leak in _ep_nuke found > > > while porting the request handling to an linked list. > > > > > > - The call of _ep_nuke can lead to an memory leak, if it is called on an > > > endpoint with currently dynamic allocated tds. This was aswell a problem > > > in the special case before the dynamic td handling was implemented and > > > an zero length packet was added to mark the end of the transfer. > > > > It is another problem, better have another commit, besides, can you > > describe more detail? > > Its possible that we add one extra request to mReq->zptr with > dma_pool_alloc in hardware_enqueu, but that one will never be released > in ep_nuke. It makes not much sense to move that fix into an extra patch > in the first place, as the codepath will be changed by this patch > anyway. So i will fix that comment above to be more clear. So, this problem also existed at old ep_nuke code? Since there is no zero td free code before. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
