Re: [PATCH v2 2/5] usb: chipidea: udc: configure iso endpoints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> I will add defines und use them.
> 
> > > +		max &= 0x7ff;	/* bit 0~10 */
> > 
> > Useless line?
> 
> Not intended. I will have to change the capability
> setting of the qh to use max instead of mEp->ep.maxpacket.
		mult = (unsigned char)(1 + ((max >> 11) & 0x03));
		mEp->qh.ptr->cap |= mult << 30;
	mEp->qh.ptr->cap |=
		(mEp->ep.maxpacket << ffs_nr(QH_MAX_PKT)) & QH_MAX_PKT;

	The above three line is not enough?
> 
> > > +		mEp->qh.ptr->cap |= mult << 30;
> > 
> > Better to use MACRO, not use number directly.
> 
> I will add defines und use them.
> 
> > > +	}
> > >  	else
> > >  		mEp->qh.ptr->cap &= ~QH_ZLT;
> > 
> > Do you plan to port all ISO supports from fsl_core_udc.c?
> 
> Can you point me to missing parts beside that.
> I did not find much more ISO related in the fsl_code_udc.

Yes, not too many. just at fsl_ep_set_halt and fsl_ep_queue
> 
> Thanks,
> Michael
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 

-- 

Best Regards,
Peter Chen

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux