Re: [PATCH 3/3] usb: Make sure each c67x00 TD has been executed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 28, 2013 at 01:08:38PM -0700, Dave Tubbs wrote:
> From: Dave Tubbs <dave.tubbs@xxxxxxxxxxxxxx>
> 
> Make sure each c67x00 TD has been executed or retry using the existing
> retry mechanism. Reference Cypress Semiconductor BIOS User's Manual 1.2,
> page 3-16
> 
> Signed-off-by: Dave Tubbs <dave.tubbs@xxxxxxxxxxxxxx>
> Acked-by: Peter Korsgaard <jacmet@xxxxxxxxxx>
> ---
>  drivers/usb/c67x00/c67x00-sched.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/c67x00/c67x00-sched.c b/drivers/usb/c67x00/c67x00-sched.c
> index aa49162..dd5bdb4 100644
> --- a/drivers/usb/c67x00/c67x00-sched.c
> +++ b/drivers/usb/c67x00/c67x00-sched.c
> @@ -1033,6 +1033,12 @@ static inline void c67x00_check_td_list(struct c67x00_hcd *c67x00)
>  		    !td_acked(td))
>  			goto cont;
> 
> +		/*
> +		 * at this point, there are no errors, but it's still possible
> +		 * that the td wasn't executed by the c67x00. Confirm it was
> +		 * executed or force a retry
> +		 */
> +		if ((td->retry_cnt & TD_RETRYCNTMASK_ACT_FLG) &&
> +		    td->status == 0)
> +			goto cont;
> +

I'm guessing you created this patch by hand, and didn't use git to
generate it, right?  It's not in a valid patch format because of that,
please create it properly so it can actually be applied.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux