On Mon, Feb 25, 2013 at 07:16:26PM +0100, Robert Jarzmik wrote: > Felipe Balbi <balbi@xxxxxx> writes: > > > this is not caused by current pull request. Well, you could argue that > > commit 70189a63d408d4ea0cddbf0ff0afe6020844e813 (usb: gadget: > > pxa27x_udc: convert to udc_start/udc_stop) is the culprit, but the fact > > is that what pxa27x is doing is pretty wrong. > No need to argue, I'm only looking for a fix :) > I just hope this change will still enable to change the gadget (ie. switch from > g_ether to g_zero by rmmoding/modprobing). > > > The bug is that pxa27x_udc tries to register gadget->dev at udc_start() > > time and that's only called after gadget driver has already been bound > > to the controller. Since commit above converted pxa27x to > > udc_start()/udc_stop() calls, it exposed the issue. > > > > Anyway, this patch should fix it (I didn't even compile test it, since > > pxa27x still depends on its architecture, which needs to be fixed). > > I suppose you made that patch against your own tree, not linux-next nor Linus's > tree. > But anyway, I took your changes into linux-next and it solves the problem. > > So please take my : > Tested-by: Robert Jarzmik <robert.jarzmik@xxxxxxx> thanks, will add your tested-by for sure. > I think the same problem occurs on other drivers. Out of my head I see : > - pxa25x_udc.c > - s3c2410_udc.c > - imx_udc_start.c Thank you, I'll patch those too unless someone beats me to it ;-) -- balbi
Attachment:
signature.asc
Description: Digital signature
