On Wed, 2013-02-20 at 17:02 +0100, Johan Hovold wrote: > These patches against tty-next fix a few issues with tty-port hangup and > close. > > The first and third patch are essentially clean ups. > > The second patch makes sure DTR is dropped also on hangup and that DTR > is only dropped for initialised ports (where is could have been raised > in the first place). > > The fourth and final patch, make sure no tty callbacks are made from > tty_port_close_start when the port has not been initialised (successfully > opened). This was previously only done for wait_until_sent but there's > no reason to call flush_buffer or to honour port drain delay either. > The latter could cause a failed open to stall for up to two seconds. > > As a side-effect, this patches also fix an issue in USB-serial where we > could get tty-port callbacks on an uninitialised port after having hung > up and unregistered a device after disconnect. > > Johan Looks good to me. No further objections :) > Changes since RFC-series: > - fix up the two driver relying on tty_port_close_start directly but > that did not manage DTR themselves > > > Johan Hovold (4): > TTY: clean up port shutdown > TTY: fix DTR not being dropped on hang up > TTY: clean up port drain-delay handling > TTY: fix close of uninitialised ports > > drivers/tty/mxser.c | 4 +++ > drivers/tty/n_gsm.c | 4 +++ > drivers/tty/tty_port.c | 71 ++++++++++++++++++++++++++++++-------------------- > 3 files changed, 51 insertions(+), 28 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
