On Mon, Feb 18, 2013 at 11:09:53AM +0100, Hannes Reinecke wrote: >The PCI config space reseves a byte for the interrupt line, >so irq 255 actually refers to 'not set'. >However, the 'irq' field for struct pci_dev is an integer, >so the original meaning is lost, causing the system to >assign an interrupt '255', which fails. > >So we should _not_ assign an interrupt value here, and >allow upper layers to fixup things. > >This patch make PCI devices with MSI interrupts only >(like the xhci device on certain HP laptops) work properly. Just tested and it works for me. Thank you. Tested-by: David Härdeman <david@xxxxxxxxxxx> >Cc: Frederik Himpe <fhimpe@xxxxxxxxx> >Cc: Oliver Neukum <oneukum@xxxxxxx> >Cc: David Haerdeman <david@xxxxxxxxxxx> >Cc: linux-usb@xxxxxxxxxxxxxxx >Cc: linux-pci@xxxxxxxxxxxxxxx >Signed-off-by: Hannes Reinecke <hare@xxxxxxx> > >diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c >index 6186f03..a2db887f 100644 >--- a/drivers/pci/probe.c >+++ b/drivers/pci/probe.c >@@ -923,7 +923,8 @@ static void pci_read_irq(struct pci_dev *dev) > dev->pin = irq; > if (irq) > pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq); >- dev->irq = irq; >+ if (irq < 255) >+ dev->irq = irq; > } > > void set_pcie_port_type(struct pci_dev *pdev) > -- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
