Hello. On 17-02-2013 5:29, Tony Camuso wrote:
Sergei,
Thank you for your response.
On 02/16/2013 11:32 AM, Sergei Shtylyov wrote:
Commit 71c731a
Please also specify that commit's summary in parens (or however you like).
Yes, I will re-submit with an excerpt of the summary. It's rather long, so I will just take the first paragraph, rather than all the details.
No need to take that paragraph, just take the patch's subject line -- this is a called summary.
+ del_timer_sync(&xhci->comp_mode_recovery_timer); + xhci_dbg(xhci, "Compliance Mode Recovery Timer Deleted!\n");
Why all words capitalized?
Another cut-and-paste from what was already put there by the above commit. I can understand why "Compliance Mode Recovery Timer" is capitalized, since it could be considered a proper name, but "Deleted" at least should be lower-cased.
Yep.
+ } + /* Let the USB core know _both_ roothubs lost power. */ usb_root_hub_lost_power(xhci->main_hcd->self.root_hub); usb_root_hub_lost_power(xhci->shared_hcd->self.root_hub); @@ -1071,7 +1078,7 @@ int xhci_resume(struct xhci_hcd *xhci, bool hibernated) * to suffer the Compliance Mode issue again. It doesn't matter if * ports have entered previously to U0 before system's suspension. */ - if (xhci->quirks & XHCI_COMP_MODE_QUIRK) + if ((xhci->quirks & XHCI_COMP_MODE_QUIRK) && (!hibernated))
Again, no need for () around !x.
I own this one :)
I will change it.
Thanks.
Regards, Tony
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
