Hi, On Fri, Feb 15, 2013 at 09:11:33PM +0530, Vivek Gautam wrote: > On Fri, Feb 15, 2013 at 6:45 PM, Felipe Balbi <balbi@xxxxxx> wrote: > > Hi, > > > > On Fri, Feb 15, 2013 at 04:40:43PM +0530, Vivek Gautam wrote: > >> Hi Felipe, > >> > >> > >> On Tue, Feb 12, 2013 at 2:17 PM, Felipe Balbi <balbi@xxxxxx> wrote: > >> > Add support for basic power management on > >> > the dwc3 driver. While there is still lots > >> > to improve for full PM support, this minimal > >> > patch will already make sure that we survive > >> > suspend-to-ram and suspend-to-disk without > >> > major issues. > >> > > >> > Cc: Vikas C Sajjan <vikas.sajjan@xxxxxxxxxx> > >> > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > >> > >> Testing this patch-series on usb-next actually giving us an issue. > >> We are not able to resume either of Host or Device. > >> Tried to find the cause, which actually came out to be missing phy_shutdown() > >> and phy_init() calls in suspend() and resume() respectively. > >> > >> Please see more comments below. > > > > great, I'll do that. Thanks a lot for testing. Should I add your > > Tested-by ? > Sure please :-) > > Also wanted to know about the other issue too. :-) > Kernel warning coming when target is attached to host while resuming, > i shall dig into that although on monday ;-) I believe the branch you tested has the udc state tracking mechnism merged, I've been wondering myself if sysfs_notify() can be called from atomic context and I guess it can't. See if removing calls to usb_gadget_set_state() from drivers/usb/dwc3/ep0.c makes the warnings go away, if it does, then we have our answer. -- balbi
Attachment:
signature.asc
Description: Digital signature
