Re: [PATCH] net: cdc_ncm: fix probing of devices with multiple control interface altsettings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Bjørn Mork <bjorn@xxxxxxx>
Date: Wed, 13 Feb 2013 23:09:52 +0100

> commit bd329e1 ("net: cdc_ncm: do not bind to NCM compatible MBIM devices")
> added a test for a CDC MBIM altsetting, implementing the cdc_ncm part of
> MBIM backward compatibility support.  This intentionally made the driver
> behave differently for CDC NCM devices with 2 alternate settings for the
> Communication interface, depending on whether or not CONFIG_USB_NET_CDC_MBIM
> was enabled.  This is correct iff alternate setting #1 really *is* a MBIM
> setting.  If not, then NCM probing will use a different altsetting than before,
> possibly causing probing failures depending on CONFIG_USB_NET_CDC_MBIM.
> 
> Fix by setting the altsetting back to default after the test, restoring the
> previous behaviour for non MBIM devices.
> 
> This bug causes probing of Huawei E3276 devices to fail when the MBIM driver
> is enabled, because these devices have a second alternate setting with no CDC
> functional descriptors.
> 
> Cc: Greg Suarez <gsuarez@xxxxxxxxxxxxxx>
> Cc: Alexey Orishko <alexey.orishko@xxxxxxxxxxxxxx>
> Reported-and-tested-by: Jonathan A. <yo.natan@xxxxxxxxxxx>
> Signed-off-by: Bjørn Mork <bjorn@xxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux