Re: [PATCH v3 2/5] HCD files for the DWC2 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sat, Feb 09, 2013 at 07:37:49PM -0800, Paul Zimmerman wrote:
> +void dwc2_hcd_start(struct dwc2_hcd *hcd)
> +{
> +	u32 hprt0;
> +
> +	if (hcd->op_state == B_HOST) {
> +		/*
> +		 * Reset the port. During a HNP mode switch the reset
> +		 * needs to occur within 1ms and have a duration of at
> +		 * least 50ms.
> +		 */
> +		hprt0 = dwc2_read_hprt0(hcd);
> +		hprt0 |= HPRT0_RST;
> +		writel(hprt0, hcd->regs + HPRT0);
> +	}
> +
> +	queue_delayed_work(hcd->wq_otg, &hcd->start_work, msecs_to_jiffies(50));

we _do_ have a generic asychronous function call in the kernel for
driver initialization, can you use that instead ?

Many of the comments to patch 1 are still valid here, but I'll save you
the trouble of reading them again ;-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux