Hi Bhupesh, On Thursday 07 February 2013 23:39:07 Laurent Pinchart wrote: > On Wednesday 30 January 2013 15:56:52 Bhupesh SHARMA wrote: > > On Monday, January 21, 2013 6:16 PM Laurent Pinchart wrote: > > > On Friday 18 January 2013 20:46:59 Felipe Balbi wrote: > > > > On Thu, Jan 17, 2013 at 04:23:48PM +0530, Bhupesh Sharma wrote: > > > > > This patchset tries to enhance the UVC webcam gadget driver and is > > > > > based on Laurent's git tree available here (head uvc-gadget): > > > > > git://linuxtv.org/pinchartl/uvcvideo.git > > > > > > > > > > Note that to ease review and integration of these patches, I have > > > > > rebased them on Laurent's repo and all the relevant patches after > > > > > review can be pushed in Felipe's repo in one go. > > > > > > > > > > The patches 3/5 and 4/5 in this patchset try to handle all the > > > > > review comments received on the following UVC gadget related > > > > > patches: > > > > > > > > > > [PATCH V2 1/2] usb: gadget/uvc: Port UVC webcam gadget to use > > > > > videobuf2 framework [PATCH V2 2/2] usb: gadget/uvc: Add support for > > > > > 'USB_GADGET_DELAYED_STATUS' response for a set_intf(alt-set 1) > > > > > command > > > > > > > > > > which can be viewed here: > > > > > [1] http://www.spinics.net/lists/linux-usb/msg68297.html > > > > > [2] http://www.spinics.net/lists/linux-usb/msg68298.html > > > > > > > > > > I have tested this patchset on a super-speed compliant USB device > > > > > controller (DWC3), with the VIVI capture device acting as a dummy > > > > > source of video data and I also have modified the 'uvc-gadget' > > > > > application written by Laurent (original application available here: > > > > > http://git.ideasonboard.org/uvc-gadget.git) for testing the complete > > > > > flow from V4L2 to UVC domain and vice versa. > > > > > > > > Laurent, do you wanna queue this yourself or should I take it ? > > > > > > I was away last week, please give me a couple of days to review the > > > patches. I'll take them in my tree with the other UVC gadget patches I > > > have and I'll send you a pull request. > > > > Did you get any time to review this patchset? > > Sorry for the delay. I'm reviewing the patches now. > > I've rebased my uvcvideo-gadget branch on top of v3.8-rc6 and resolved the > conflicts. > > As your 1/5 "usb: gadget/uvc: Fix VS_INPUT_HEADER.bEndpointAddress and Video > Streaming.bEndpointAddress values" patch fixes a bug introduced in "usb: > gadget/uvc: Configure the streaming endpoint based on the speed", do you > mind if I squash it with that commit to avoid breaking bisection ? I've reviewed patches 1/5, 2/5, 4/5 and 5/5. I will handle patch 3 tomorrow. I have fixed the issue introduced by my "usb: gadget/uvc: Configure the streaming endpoint based on the speed" patch in the patch itself, so I haven't applied 1/5. 2/5 and 5/5 need to be reworked a bit. I've applied 4/5 to my tree and pushed the result to the uvcvideo-gadget branch on git://linuxtv.org/pinchartl/uvcvideo.git. Would you be able to test that branch ? If there's no issue I'll send a pull request to Felipe. > > I would like to send other patches which eliminate the need for doing any > > copy from CPU to copy the video frame into the USB request's buffer, > > in-case the underlying UDC controller supports Scatter-Gather DMA. > > Very nice ! > > > I plan to queue them up after you merge all the UVC related patches to > > your repo and send a pull request to Felipe, so that I can rebase the new > > patches on top of the merged repo. > > OK, I'll speed up review of this patch series. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
