On Tuesday 05 February 2013, Felipe Balbi wrote: > [linus/master] Merge branch 'fix-max-write' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm > > It's building find for me: > > $ crossmake drivers/usb/gadget/fsl_udc_core.o \ > drivers/usb/gadget/fsl_mxc_udc.o > /dev/null > > (crossmake is an alias to make ARCH=arm) > > Arnd, are you maybe missing a merge of v3.8-rc6 ? > > I can see that imx_udc.c is broken still, but there are no maintainers > for that driver. I'm adding Sascha to Cc list, maybe he knows someone > who can help, but if this driver isn't fixed in 2 merge windows, I will > schedule for removal from tree and someone else will have to > re-introduce it later without all the bogus includes. Ah, I see what happened now: I submitted a patch that lumped together two patches, disabling both fsl_mxc_udc and imx_udc. You already had a fix for the first one, so I dropped my patch, but now I see the build error for the second one that my patch was avoiding. The last patch to imx_udc that seems to have seen more than just build testing was probably "USB: gadget: imx_udc: don't queue more data when zlp is to be sent", while fsl_mxc_udc looks actively maintained. It's not completely clear to me whether these are actually two drivers for the same hardware, of whether imx_udc is the i.mx1 variant and fsl_mxc_udc is the i.mx2 variant. What I can say is that no platform in the kernel currently defines an "imx_udc" platform_device, so it is certainly unused, and has been since at least e08300043e in 2010. I would suggest that we mark the imx_udc driver as 'depends on BROKEN' right away, since no in-tree user needs it, and any out of tree user is already broken in 3.8. I also wouldn't mind removing the driver unless the imx maintainers have a plan for it. > ---- build breaks --- > > sound/soc/fsl/imx-pcm.c: In function 'snd_imx_pcm_mmap': > sound/soc/fsl/imx-pcm.c:28:2: error: 'KBUILD_MODNAME' undeclared (first use in this function) > sound/soc/fsl/imx-pcm.c:28:2: note: each undeclared identifier is > reported only once for each function it appears in > make[3]: *** [sound/soc/fsl/imx-pcm.o] Error 1 > > drivers/video/omap2/dss/dss.c: In function 'dss_calc_clock_div': > drivers/video/omap2/dss/dss.c:572:20: error: > 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared (first use in this function) > drivers/video/omap2/dss/dss.c:572:20: note: each undeclared identifier > is reported only once for each function it appears in > make[4]: *** [drivers/video/omap2/dss/dss.o] Error 1 Yes, I submitted patches for these, too, and like this case, we decided to drop my patch in favor of a better fix, which has not yet gone in. Today I sent emails about these as well, in the hope that we can find a solution. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
