On Tuesday 29 January 2013 07:23 PM, Wolfram Sang wrote:
+ err = of_property_read_string(np, "phy_type", &phy_type);
+ if (err < 0)
+ return USBPHY_INTERFACE_MODE_NA;
Why don't we use a u32 property type for the *phy-type*? IMHO we
should use string property only when the property should be
absolutely unambiguous (e.g., compatible property should be string).
If we would use u32-numbers in the compatible entry, this would also be
unambiguous, no? 0xd00dfeed would be the at24-driver. Pretty specific.
hehe... But we don't have a corresponding *enum* representing the
drivers :-)
I don't mind having readable devicetrees. And we have it for ethernet
phys already with strings, so it would be consistent.
Ok. Fine with it then :-)
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
