Re: [PATCH 03/13] MIPS: BCM63XX: move code touching the USB private register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Jan 28, 2013 at 10:17:15PM +0100, Florian Fainelli wrote:
> On Monday 28 January 2013 22:41:14 Felipe Balbi wrote:
> > Hi,
> > 
> > On Mon, Jan 28, 2013 at 08:06:21PM +0100, Florian Fainelli wrote:
> > > diff --git a/drivers/usb/gadget/bcm63xx_udc.c b/drivers/usb/gadget/bcm63xx_udc.c
> > > index ad17533..af450c4 100644
> > > --- a/drivers/usb/gadget/bcm63xx_udc.c
> > > +++ b/drivers/usb/gadget/bcm63xx_udc.c
> > > @@ -41,6 +41,7 @@
> > >  #include <bcm63xx_dev_usb_usbd.h>
> > >  #include <bcm63xx_io.h>
> > >  #include <bcm63xx_regs.h>
> > > +#include <bcm63xx_usb_priv.h>
> > 
> > actually, I want to see this arch dependency vanish. The whole
> > "phy_mode" stuff should be a PHY driver, care to implement this properly
> > using the PHY layer ?
> 
> Ok, but then I won't be able to use the generic OHCI and EHCI platform drivers
> because they are not yet aware of clocks, PHY slave device etc... For now I
> would like to stick with that since this is also very BCM63xx centric.
> 
> Would that be ok with you?

sure, but we need to see a move towards making all of this generic and,
perhaps more importantly (at least to me), compilable on all arches so
we can make proper use of linux-next and Fengguang's build systems.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux