Re: [PATCH v2] usb: add driver for xsens motion trackers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 25, 2013 at 6:47 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:

> There's no reason for restricting i to be 8 bits.  It isn't a field in
> a structure or a member of an array, so saving space isn't an issue.
> Neither is sign extension.  Why force the compiler to go to extra
> effort when using a natural-sized integer will work just as well?

I'm not very keen on introducing possible warnings about
signed/unsigned comparison or somesuch. Of course I could have done
something like

int num_endpoints = interface->desc.bNumEndpoints;
int i;

for (...)

to remove any warnings. It would of course depend on the warning level
you're compiling with. It's not a big deal to me to change it, if
anyone insists.

Thanks,
Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux