Re: [RFC/PATCH v3 1/3] usb: common: introduce usb_state_string()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 25, 2013 at 09:47:16AM +0200, Felipe Balbi wrote:
> On Fri, Jan 25, 2013 at 03:45:37PM +0800, Peter Chen wrote:
> > On Thu, Jan 24, 2013 at 10:40:36PM +0200, Felipe Balbi wrote:
> > > this function will receive enum usb_device_state
> > > and return a human-readable string from it or,
> > > case an unknown value is passed as argument,
> > > the string "UNKNOWN".
> > > 
> > > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > > ---
> > >  drivers/usb/usb-common.c | 21 +++++++++++++++++++++
> > >  include/linux/usb/ch9.h  |  9 +++++++++
> > >  2 files changed, 30 insertions(+)
> > > 
> > > diff --git a/drivers/usb/usb-common.c b/drivers/usb/usb-common.c
> > > index d29503e..070b681 100644
> > > --- a/drivers/usb/usb-common.c
> > > +++ b/drivers/usb/usb-common.c
> > > @@ -32,4 +32,25 @@ const char *usb_speed_string(enum usb_device_speed speed)
> > >  }
> > >  EXPORT_SYMBOL_GPL(usb_speed_string);
> > >  
> > > +const char *usb_state_string(enum usb_device_state state)
> > > +{
> > > +	static const char *const names[] = {
> > > +		[USB_STATE_NOTATTACHED] = "not attached",
> > > +		[USB_STATE_ATTACHED] = "attached",
> > > +		[USB_STATE_POWERED] = "powered",
> > > +		[USB_STATE_RECONNECTING] = "reconnecting",
> > > +		[USB_STATE_UNAUTHENTICATED] = "unauthenticated",
> > > +		[USB_STATE_DEFAULT] = "default",
> > > +		[USB_STATE_ADDRESS] = "addresssed",
> > > +		[USB_STATE_CONFIGURED] = "configured",
> > > +		[USB_STATE_SUSPENDED] = "suspended",
> > > +	};
> > 
> > What does the "reconnecting" means?
> > Besides, can we have a brief comment about the meaning of these string?
> > For the host sends resume signal to device when the device is at suspended
> > mode, do we need to add "resumed" state?
> 
> why resumed ? after resuming you go back to default or addressed or
> configured states.

Get it
> 
> -- 
> balbi



-- 

Best Regards,
Peter Chen

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux