Re: [PATCH] usb: Prevent dead ports when xhci is not enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 24, 2013 at 09:04:29AM -0800, Sarah Sharp wrote:
> On Thu, Jan 24, 2013 at 06:49:49AM -0800, Greg KH wrote:
> > On Wed, Jan 23, 2013 at 10:19:49PM -0800, David Moore wrote:
> > > From: David Moore <david.moore@xxxxxxxxx>
> > > 
> > > When the xHCI driver is not available, actively switch the ports to EHCI
> > > mode since some BIOSes leave them in xHCI mode where they would
> > > otherwise appear dead.
> > > 
> > > Signed-off-by: David Moore <david.moore@xxxxxxxxx>
> > > ---
> > >  drivers/usb/host/pci-quirks.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> > > index eb5563a..7893351 100644
> > > --- a/drivers/usb/host/pci-quirks.c
> > > +++ b/drivers/usb/host/pci-quirks.c
> > > @@ -780,6 +780,7 @@ void usb_enable_xhci_ports(struct pci_dev *xhci_pdev)
> > >  				"defaulting to EHCI.\n");
> > >  		dev_warn(&xhci_pdev->dev,
> > >  				"USB 3.0 devices will work at USB 2.0 speeds.\n");
> > > +		usb_disable_xhci_ports(xhci_pdev);
> > 
> > Any specifics as to exactly what hardware types need this patch?
> 
> David saw this on a Dell Optiplex 7010, but it's possible other systems
> could be affected.  Most people will turn on the xHCI config option and
> not notice this issue.

Can that go into the changelog somewhere?

> > I'm guessing this should also go to the stable kernel releases as well?
> 
> Yes, from 3.0 onwards, to fix commit
> 69e848c2090aebba5698a1620604c7dccb448684 "Intel xhci: Support EHCI/xHCI
> port switching."

Ok, can you add this to the patch when you apply it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux