On Thu, Jan 24, 2013 at 09:28:32PM +0530, BVG Rao wrote: > On Thu, Jan 24, 2013 at 7:35 PM, Felipe Balbi <balbi@xxxxxx> wrote: > > Hi, > > > > On Thu, Jan 24, 2013 at 03:57:03PM +0530, Venu Byravarasu wrote: > >> As pointer to PHY structure can be stored in struct usb_hcd > >> making use of it, to call Tegra PHY APIs. > >> > >> Call to usb_phy_shutdown() is moved up in tegra_ehci_remove(), > >> so that to avoid dereferencing of hcd after its freed up. > >> > >> Signed-off-by: Venu Byravarasu <vbyravarasu@xxxxxxxxxx> > >> --- > >> First version of patch can be found at > >> http://marc.info/?l=linux-kernel&m=135581479020213&w=2. As it was not > >> yet applied, sending v2 of the patch. > >> > >> delta from v1: > >> Modified all Tegra PHY APIs to use standard 'structu usb_phy *' as > >> their parameter instead of proprietary parameter of type 'struct tegra_usb_phy *'. > > > > I would like to see those tegra-specific functions vanish from the > > driver. Can that be done for v3.10 merge window ? > > Deleting these functions may not be possible because of the way, > Tegra20 USB PHY and controllers are designed. > Hence I'm trying to remove tegra specific structure pointers as > function parameter > and use generic USB PHY structure pointers instead. yes, you need to use generic function pointers, that's what I meant. -- balbi
Attachment:
signature.asc
Description: Digital signature
