Re: [PATCH 2/2] drivers/usb/host/uhci-*: beautify source code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 23 Jan 2013, Chen Gang wrote:

> 
>   get rid of the line breaks in string constants.
>   let comments within 80 with limitation.
>   delete ' \' at the end of a statement.
> 
> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>

This is good except for...

> --- a/drivers/usb/host/uhci-hub.c
> +++ b/drivers/usb/host/uhci-hub.c
> @@ -21,8 +21,10 @@ static const __u8 root_hub_hub_des[] =
>  	0x00,			/*   (per-port OC, no power switching) */
>  	0x01,			/*  __u8  bPwrOn2pwrGood; 2ms */
>  	0x00,			/*  __u8  bHubContrCurrent; 0 mA */
> -	0x00,			/*  __u8  DeviceRemovable; *** 7 Ports max *** */
> -	0xff			/*  __u8  PortPwrCtrlMask; *** 7 ports max *** */
> +	0x00,			/*  __u8  DeviceRemovable; *** 7 Ports max ***
> +				 */
> +	0xff			/*  __u8  PortPwrCtrlMask; *** 7 ports max ***
> +				 */

Here you could just get rid of the second *** on each line.  Or put the 
"7 ports max" into parentheses and get rid of all the ***'s.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux